Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: store the corpus #5363

Merged
merged 22 commits into from
Oct 14, 2023
Merged

fuzz: store the corpus #5363

merged 22 commits into from
Oct 14, 2023

Conversation

tommady
Copy link
Contributor

@tommady tommady commented Oct 6, 2023

fulfill #5312

@cakebaker cakebaker linked an issue Oct 6, 2023 that may be closed by this pull request
@tertsdiepraam
Copy link
Member

Small tip: if you use one of the keywords that GitHub recognizes (i.e fixes or closes instead of fulfill) it will automatically link the issue to the PR: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

@tommady
Copy link
Contributor Author

tommady commented Oct 6, 2023

Note: You can only download artifacts in a workflow that were uploaded during the same workflow run.

hi @sylvestre
I am sorry the github artifacts way is not working.

specifically, the download can only be used in the same workflow as the doc said,
so maybe we should consider creating a new repo to store the corpus.

so the new plan:

  1. a new repo for storing the corpus
  2. github action upload or commit corpus in there
  3. github action download or clone corpus from there

or I am sure the artifact has been uploaded into this repo,
but I don't have the permission to see it,
if I can we could consider using the github cli instead for the downloading.

WDYT?

@sylvestre
Copy link
Contributor

i think you might want to try the cache storage? no?

@sylvestre
Copy link
Contributor

new repo sounds great too :)

@tommady
Copy link
Contributor Author

tommady commented Oct 11, 2023

i think you might want to try the cache storage? no?

That sounds great, let me do some study and try on this
https:/actions/cache

thank you

@tommady
Copy link
Contributor Author

tommady commented Oct 12, 2023

Hi @sylvestre
the cache action working!
image

with and without cache the time compression

https:/uutils/coreutils/actions/runs/6468556171/job/17560815053
9m 36s
vs
https:/uutils/coreutils/actions/runs/6491029799/job/17627703803?pr=5363
8m 51s

@tommady tommady marked this pull request as ready for review October 12, 2023 04:16
@sylvestre
Copy link
Contributor

and it seems that it works:
2023-10-12T03:56:14.2306567Z INFO: 854 files found in /home/runner/work/coreutils/coreutils/fuzz/corpus/fuzz_date

@sylvestre
Copy link
Contributor

Bravo :)

@sylvestre sylvestre merged commit f979f14 into uutils:main Oct 14, 2023
43 of 45 checks passed
@sylvestre
Copy link
Contributor

Many thanks

@sylvestre
Copy link
Contributor

and it works!

INFO: 93 files found in /home/runner/work/coreutils/coreutils/fuzz/corpus/fuzz_expr
well done

@tommady tommady deleted the fix-5312 branch October 15, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fuzz: store the corpus
3 participants