Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: short-circuit evaluation for | #5365

Merged
merged 6 commits into from
Oct 8, 2023
Merged

expr: short-circuit evaluation for | #5365

merged 6 commits into from
Oct 8, 2023

Conversation

Luv-Ray
Copy link
Contributor

@Luv-Ray Luv-Ray commented Oct 6, 2023

fix #5326
Implement short-circuit evaluation for |. And add the corresponding test.

@Luv-Ray Luv-Ray requested a review from sylvestre October 7, 2023 02:52
@Luv-Ray
Copy link
Contributor Author

Luv-Ray commented Oct 7, 2023

As I am not familiar with PR, I may have done something wrong, sorry about that. I think the branch is clean now.
Is the implementation in the code inappropriate or incorrect?

@cakebaker cakebaker merged commit 94f5fa9 into uutils:main Oct 8, 2023
44 of 45 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expr 1 \| a / 5 is producing different results than GNU
3 participants
@Luv-Ray @cakebaker @sylvestre