Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: In some cases, remove_dir is doing a better job than remove_dir_all #5403

Merged
merged 2 commits into from
Oct 16, 2023
Merged

rm: In some cases, remove_dir is doing a better job than remove_dir_all #5403

merged 2 commits into from
Oct 16, 2023

Conversation

sylvestre
Copy link
Contributor

use it when remove_dir_all failed

GNU compatibility (rm/empty-inacc.sh)

@sylvestre
rm: In some cases, remove_dir is doing a better job than remove_dir_all
505ef71 
use it when remove_dir_all failed

GNU compatibility (rm/empty-inacc.sh)
@sylvestre
Copy link
Contributor Author

it doesn't fully fix the test
Next is

fail=0
mkdir -m a-r -p a/unreadable
rm -rf a
echo $fail
test -d a && fail=1
echo $fail

which should pass

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/rm/unreadable is no longer failing!

@sylvestre
Copy link
Contributor Author

GNU testsuite comparison:

Congrats! The gnu test tests/rm/unreadable is no longer failing!

Well this is an unexpected good result :)

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/rm/unreadable is no longer failing!

@cakebaker cakebaker merged commit 541ac6a into uutils:main Oct 16, 2023
44 of 45 checks passed
@tertsdiepraam tertsdiepraam mentioned this pull request Oct 31, 2023
Open
@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
@moonfruit moonfruit mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker Awaiting requested review from cakebaker

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker