split : --filter and stdin updates
#5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
|
@sylvestre would you mind reviewing this one? |
sylvestre
reviewed
Oct 18, 2023
src/uu/split/src/split.rs
Outdated
| @@ -748,6 +748,9 @@ enum SettingsError { | |||
| /// Multiple different separator characters | |||
| MultipleSeparatorCharacters, | |||
|
|
|||
| /// Using `--filter` with Kth chunk options that output to stdout | |||
There was a problem hiding this comment.
could you please explain what means Kth ? :)
There was a problem hiding this comment.
sure, using any of the sub-variants of the --number option that prints Kth of N chunks to stdout, like:
K/N output Kth of N to stdout
l/K/N output Kth of N to stdout without splitting lines/records
r/K/N likewise but only output Kth of N to stdout
i.e. --number=2/5 or --number=l/1/10 or --number=r/9/22 , etc.
There was a problem hiding this comment.
sorry, i mean in the comment :)
There was a problem hiding this comment.
got it, pushed an update
|
GNU testsuite comparison: |
bravo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor handling of
--filteroption, specifically BrokenPipe error handling - for "endless" and finite inputs.Better handling of stdin input errors for
--numberoption.Following GNU
splitbehavior for above.GNU test tests/split/filter.sh should stop failing