Expand CONTRIBUTING.md (WIP) #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
force-pushed
the
contribution-md
branch
from
9f5a705
to
8dfad81
Compare
tertsdiepraam
force-pushed
the
contribution-md
branch
from
8dfad81
to
3d0c8ae
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Nov 7, 2023
CONTRIBUTING.md
Outdated
| Write your commit message in the imperative: "Fix bug" and not "Fixed bug" | ||
| or "Fixes bug." This convention matches up with commit messages generated | ||
| by commands like git merge and git revert. | ||
| There are several ways to help and writing code is just one them. Reporting |
There was a problem hiding this comment.
Suggested change
| There are several ways to help and writing code is just one them. Reporting | |
| There are several ways to help and writing code is just one of them. Reporting |
cakebaker
reviewed
Nov 7, 2023
CONTRIBUTING.md
Outdated
| to fix yet, make one _before_ you start working on the PR. | ||
|
|
||
| Generally, we try to follow what GNU is doing in terms of options and behavior. | ||
| It is recommended to look at the GNU Coreutils manual |
There was a problem hiding this comment.
Suggested change
| It is recommended to look at the GNU Coreutils manual | |
| It is recommended to look at the GNU coreutils manual |
tertsdiepraam
force-pushed
the
contribution-md
branch
from
59efe75
to
f5709de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards #5195
The sections "Design Goals" and "Git Etiquette" are still left empty. We can discuss what we what to put there.