Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand: remove crash! macro #5510

Merged
merged 4 commits into from
Nov 10, 2023
Merged

expand: remove crash! macro #5510

merged 4 commits into from
Nov 10, 2023

Conversation

ceteece
Copy link
Contributor

@ceteece ceteece commented Nov 7, 2023

Related issue: #5487

Removes use of crash! macro in expand

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail/symlink is no longer failing!

ceteece
ceteece commented Nov 8, 2023
View reviewed changes
src/uu/expand/src/expand.rs Outdated Show resolved Hide resolved
@ceteece ceteece marked this pull request as ready for review November 9, 2023 05:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

GNU testsuite comparison:

GNU test failed: tests/tail/symlink. tests/tail/symlink is passing on 'main'. Maybe you have to rebase?

tertsdiepraam
tertsdiepraam reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! One tiny suggestion, otherwise ready to be merged!

src/uu/expand/src/expand.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?

@cakebaker cakebaker merged commit 7202d01 into uutils:main Nov 10, 2023
47 of 51 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR :)

@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
@moonfruit moonfruit mentioned this pull request Nov 17, 2023
Merged
@allaboutevemirolive allaboutevemirolive mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceteece @cakebaker @tertsdiepraam