Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzzing: Refactor the error management #5517

Merged
merged 6 commits into from
Nov 10, 2023
Merged

fuzzing: Refactor the error management #5517

merged 6 commits into from
Nov 10, 2023

Conversation

sylvestre
Copy link
Contributor

  • compares exit code, stdout & stderr (the later can be disabled)
  • add checks on pipe operations
  • flush before getting the results for stdout & stderr

@uutils uutils deleted a comment from github-actions bot Nov 9, 2023
tertsdiepraam
tertsdiepraam reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small suggestion

fuzz/fuzz_targets/fuzz_common.rs Show resolved Hide resolved
@uutils uutils deleted a comment from github-actions bot Nov 10, 2023
@sylvestre sylvestre merged commit 312baed into uutils:main Nov 10, 2023
49 of 51 checks passed
@sylvestre sylvestre deleted the fuzzing-improv branch November 10, 2023 21:21
@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
@moonfruit moonfruit mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @tertsdiepraam