Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishing: check if the current version is already there or not #5535

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

sylvestre
Copy link
Contributor

This can happen when a publishing step failed

This can happen when a publishing step failed
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/symlink. tests/tail/symlink is passing on 'main'. Maybe you have to rebase?

Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks fine. I'm not sure about the API access because according to https://crates.io/data-access they allow "[a] maximum of 1 request per second" and so I guess we could run into this restriction.

Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to explore external tools for this process as well, but I think we can discuss that in another issue.

@sylvestre
Copy link
Contributor Author

Having worked with @Gankra before, I am sure https:/axodotdev/cargo-dist is an excellent candidate for this :)

@tertsdiepraam
Copy link
Member

I love everything this axo does, but I don't think cargo-dist is the full solution here. They even say in the docs that some steps should be left to cargo-release (https://opensource.axo.dev/cargo-dist/book/workspaces/cargo-release-guide.html). I'd still love to try out cargo-dist though! Especially with all the talk around Windows installers recently.

@sylvestre sylvestre merged commit 02dc6ee into uutils:main Nov 19, 2023
50 of 54 checks passed
@sylvestre sylvestre deleted the check-version branch November 23, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants