-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Percentage in buffer-size in sort #5616
Conversation
@zeroishero did you see that |
@cak when I had checked it, it had shown failed only on Android. I will check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions, but very nice!
I'm wondering about the sysinfo crate though because it doesn't seem to be doing the same as GNU under the hood. strace
reveals that GNU uses the sysinfo
syscall and that this crate reads some file with memory info. Ultimately, we might want to switch to something else. So maybe we should add a comment for that in the code. I still think we can accept this version though.
Co-authored-by: Terts Diepraam <[email protected]>
GNU testsuite comparison:
|
GNU testsuite comparison:
|
A bunch of jobs are failing |
How do I see which jobs are failing? |
GNU testsuite comparison:
|
GNU testsuite comparison:
|
GNU testsuite comparison:
|
@sylvestre I saw timeout error in another Pull request too. I wasn't able to find why it is happening. |
@zeroishero it looks unrelated to your changes. |
Fixes issue #3500 by adding support for percentags of total memory for the buffer-size flag. The sysinfo crate is used to determine the total memory of a system.
Made this instead of pr #5519