Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls: ignore invalid block size from env vars #5674

Merged

Conversation

cakebaker
Copy link
Contributor

If the block size value specified by an env variable (e.g. LS_BLOCK_SIZE) is invalid, GNU ls "ignores" the value (it changes a block size value we currently don't have) whereas uutils ls panics while creating an error. This PR fixes this issue.

@cakebaker cakebaker force-pushed the ls_ignore_invalid_block_size_from_env_vars branch from 0291b30 to a560661 Compare December 19, 2023 09:02
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate

@sylvestre sylvestre merged commit 3d42619 into uutils:main Dec 19, 2023
53 of 56 checks passed
@cakebaker cakebaker deleted the ls_ignore_invalid_block_size_from_env_vars branch December 19, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants