Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: improve the code a tiny bit #5755

Merged
merged 1 commit into from
Dec 31, 2023
Merged

rm: improve the code a tiny bit #5755

merged 1 commit into from
Dec 31, 2023

Conversation

sylvestre
Copy link
Contributor

No description provided.

@cakebaker cakebaker merged commit ed11132 into uutils:main Dec 31, 2023
55 of 56 checks passed
@sylvestre
Copy link
Contributor Author

@samueltardieu maybe you might be interested by this simple clippy potential rule :)

@samueltardieu
Copy link
Contributor

samueltardieu commented Dec 31, 2023 •
edited
Loading

maybe you might be interested by this simple clippy potential rule

Clippy assumes that _e is there for informative reasons and will not propose to remove it (it should have suggested if matches!(e, Err(_e)) though. If it had been written as if let Err(_) = e then .is_err() would have been suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sylvestre @samueltardieu @cakebaker