sync: Remove crash!

[daria-tanasie]

The issue: Remove all uses of crash! #5487
Replaced all uses of crash! from the file "src/uu/sync/src/sync.rs" with the show! macro

[alexandruradovici]

Please run cargo fmt to format your code.

[cakebaker]

I don't know if you have seen it: the CI shows some errors on Windows:

error[E0433]: failed to resolve: use of undeclared type `USimpleError`
  --> src\uu\sync\src/sync.rs:91:31
   |
91 |                         show!(USimpleError::new(
   |                               ^^^^^^^^^^^^ use of undeclared type `USimpleError`

I think you forgot a use statement.

[tertsdiepraam]

We need to be a bit careful here. show! is not equivalent to crash!, because crash! exits the program and show! doesn't. To keep the same behaviour, we therefore need to make the fallible functions return a UResult and bubble the error up to the main function. For example, we now might return an INVALID_HANDLE on like 115 to some code that might expect a valid handle.

[Kev1n8]

@daria-tanasie I wonder if you are still working on this. If not, I'd like to make some effort on it.

[Kev1n8]

@tertsdiepraam I would like to open another PR regarding this since this one has been hanging for a while, is that ok?

[sylvestre]

Sure please go ahead. :)

…

-------- Message d'origine -------- Le 07/07/2024 11:01, kf zheng a écrit :

***@***.***(https:/tertsdiepraam) I would like to open another PR regarding this since this one has been hanging for a while, is that ok? — Reply to this email directly, [view it on GitHub](#5847 (comment)), or [unsubscribe](https:/notifications/unsubscribe-auth/AAFTBDRWUURGJ72DND3LPITZLD7V7AVCNFSM6AAAAABB3RKLPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGM3TOMZTGQ). You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[sylvestre]

fixed here: #6547