Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor: rename input parameter #5892

Merged
merged 1 commit into from
Jan 28, 2024
Merged

factor: rename input parameter #5892

merged 1 commit into from
Jan 28, 2024

Conversation

kralo
Copy link
Contributor

@kralo kralo commented Jan 27, 2024

Closes: #5883

Clippy warns if there are more than 4 single-character local variables.

I looked up the original papers for that algorithm and I don't see any sense renaming x,y or d.
I see the best solution in renaming the input parameter.

src/uu/factor/src/rho.rs Outdated Show resolved Hide resolved
@sylvestre sylvestre merged commit 7fa4b38 into uutils:main Jan 28, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

factor/rho.rs: Fix #![allow(clippy::many_single_char_names)]
2 participants