more: Disable raw mode before exiting if a panic occurs

[Ideflop]

Currently, if a panic occurs, the raw mode is still active, requiring the terminal to be closed and reopened to use it again.

To test the fix, execute the following command without the new panic hook:

./target/debug/coreutils more -n 2 cargo-test.md cargo-test.md

The terminal should be unusable after running this command.

Then, execute the command with the new panic hook:

./target/debug/coreutils more -n 2 cargo-test.md cargo-test.md

The terminal should remain usable after running this command.

[tertsdiepraam]

I'm not really opposed to this, but I'd rather see the panics fixed instead. I want it to be possible to compile the coreutils with panic="abort" so I really want to discourage anything that relies on panics.

[Ideflop]

If I understand correctly, if I remove the panic inside the hook then when the code panics, it will first execute the set_hook and then execute the panic="abort" as specified in the Cargo.toml?

[tertsdiepraam]

You're right, I was confused 😅

[Ideflop]

I have made some small changes to the code. First, I have removed the panic. Secondly, I put a print !("\r") which will place the cursor at the beginning of the line and then I print the panic information.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

[cakebaker]

Thanks :)

Btw: You can use stty sane instead of closing/reopening the terminal.