Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printf: Make printf operate on bytes instead of strings #6028

Merged
merged 3 commits into from
Feb 29, 2024
Merged

printf: Make printf operate on bytes instead of strings #6028

merged 3 commits into from
Feb 29, 2024

Conversation

RenjiSann
Copy link
Contributor

Fixes #5826

Reference

❯ /bin/printf %c 🙃 | hexdump          
0000000 00f0                                   
0000001

Before

❯ ./target/debug/printf %c 🙃 | hexdump
0000000 b0c3                                   
0000002

After

❯ ./target/debug/printf %c 🙃 | hexdump 
0000000 00f0                                   
0000001

@RenjiSann
Copy link
Contributor Author

@tertsdiepraam @cakebaker

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker mentioned this pull request Feb 29, 2024
Closed
@cakebaker cakebaker merged commit 75b2bfb into uutils:main Feb 29, 2024
60 of 62 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR :)

@RenjiSann RenjiSann deleted the feature/printf-byte branch February 29, 2024 18:02
@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

printf should print a byte instead of a char
2 participants
@RenjiSann @cakebaker