Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cut: refactor delimiters OsString handling #6072

Merged
merged 1 commit into from
Mar 15, 2024
Merged

cut: refactor delimiters OsString handling #6072

merged 1 commit into from
Mar 15, 2024

Conversation

zhitkoff
Copy link
Contributor

Small refactoring of how OsString values are handled for delimiters following feedback from PR #6037

  • returning delimiter values early
  • do not create and pass around temporary OsString values
  • comments

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/mv/backup-dir is no longer failing!

@cakebaker cakebaker merged commit e450ce8 into uutils:main Mar 15, 2024
61 of 62 checks passed
@cakebaker
Copy link
Contributor

Thanks!

@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhitkoff @cakebaker