Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd: misc gnu test #6084

Merged
merged 5 commits into from
Mar 20, 2024
Merged

dd: misc gnu test #6084

merged 5 commits into from
Mar 20, 2024

Conversation

matrixhead
Copy link
Contributor

@matrixhead matrixhead commented Mar 16, 2024

this fixes the misc test case in dd, it was failing because there was this check in misc where dd should error when given the input via stdin is not a folder and iflag=directory is set.

@cre4ture
Copy link
Contributor

hi @matrixhead . it seems that we are both working on dd right now. We need to sync to avoid double work. ^^
I'm usually announcing my work with a ticket. Especially when it's something larger.

@matrixhead
Copy link
Contributor Author

matrixhead commented Mar 16, 2024

@cre4ture sorry my bad i should've done that, i will try to do that from now on also since you were working on this issue could you give me your thoughts on this pr.

@cre4ture
Copy link
Contributor

Don't worry. I'm working on dd, but I had luck that I skipped exactly this part that you where picking. So I don't expect I have much special thoughts in this PR other than other revievers. :-)

tests/by-util/test_dd.rs Outdated Show resolved Hide resolved
src/uu/dd/src/dd.rs Outdated Show resolved Hide resolved
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/misc is no longer failing!
Congrats! The gnu test tests/dd/not-rewound is no longer failing!
Congrats! The gnu test tests/timeout/timeout is no longer failing!

Co-authored-by: Daniel Hofstetter <[email protected]>
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/dd/misc is no longer failing!

@cakebaker cakebaker merged commit 660014e into uutils:main Mar 20, 2024
62 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR and great to see that tests/dd/misc passes now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants