ls: compute the correct exit code #6173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Apr 1, 2024
Note in particular that this seems to be the only tool where invalid stringly-enum values cause a different exit code than invalid arguments.
BenWiederhake
force-pushed
the
dev-ls-exit-code
branch
from
ae3885f
to
714b4ff
Compare
|
Changes since last push:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out,
ls's exit code is actually quite complex, and convincing clap to do what we need is not trivial.#6162 grew too much, and in particular
lsis a big hassle. So let's deal withlsin isolation first, and I'll rebase #6162 once this PR is merged.