Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warning match_bool #6184

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix clippy warning match_bool #6184

merged 2 commits into from
Apr 3, 2024

Conversation

sylvestre
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Apr 2, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)

@cakebaker
Copy link
Contributor

Did you see that there are still some clippy errors?

Copy link

github-actions bot commented Apr 3, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 874c4f2 into uutils:main Apr 3, 2024
64 checks passed
Comment on lines +1069 to +1074
if explicit {
(false, true)
} else {
(false, false)
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why these lines can't just be (false, explicit)? Also, when touching the code, can you document what the bools mean?

(I'm too late to the party; I hope you still have motivation to improve this?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants