Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix code coverage windows #6332

Merged
merged 1 commit into from
May 2, 2024
Merged

fix code coverage windows #6332

merged 1 commit into from
May 2, 2024

Conversation

piotrkwiecinski
Copy link
Contributor

@piotrkwiecinski piotrkwiecinski commented May 2, 2024 •
edited
Loading

On windows path to grcov is:

info: grcov installed at /c/Users/runneradmin/.install-action/bin/grcov.exe
+ grcov --version
grcov 0.8.19

On unix:

info: grcov installed at /home/runner/.cargo/bin/grcov
+ grcov --version
grcov 0.8.19

In both cases they should be available in $PATH

Tested on my fork: https:/piotrkwiecinski/coreutils/actions/runs/8926781245/job/24518622684?pr=7

Fixes #6331

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

@BenWiederhake
Copy link
Collaborator

Fantastic! The CI failure is #6275 and #6333, so not a blocker.

@BenWiederhake BenWiederhake merged commit 2d71b7c into uutils:main May 2, 2024
67 of 68 checks passed
@piotrkwiecinski piotrkwiecinski deleted the fix-windows-code-cov branch May 2, 2024 17:15
@BrewTestBot BrewTestBot mentioned this pull request Jun 23, 2024
Merged
@moonfruit moonfruit mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grcov Windows CI is broken
2 participants
@piotrkwiecinski @BenWiederhake