Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail: use #[ignore] to disable tests #6388

Merged
merged 2 commits into from
May 9, 2024

Conversation

cakebaker
Copy link
Contributor

This PR uses #[ignore] instead of #[cfg(disable_until_fixed)] to disable tests. It fixes several "unexpected cfg condition name: disable_until_fixed" warnings from the unexpected_cfgs lint (see, for example, https:/uutils/coreutils/actions/runs/8996946984/job/24714228670?pr=6378#step:11:548)

@sylvestre sylvestre merged commit b029e27 into uutils:main May 9, 2024
66 of 68 checks passed
@cakebaker cakebaker deleted the tail_ignore_some_tests branch May 9, 2024 13:47
Copy link

github-actions bot commented May 9, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@BenWiederhake
Copy link
Collaborator

It also fixes cargo test --all-features :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants