cksum: implement check (Closes: #5705) #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
force-pushed
the
cksum-check
branch
2 times, most recently
from
e0becb8
to
6b8ce37
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
should fail but getting close |
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
cksum-check
branch
3 times, most recently
from
c053907
to
40e00b6
Compare
|
GNU testsuite comparison: |
|
coreutils/coreutils@b5ce9fb I contributed this upstream as they were missing |
cakebaker
reviewed
May 12, 2024
cakebaker
reviewed
May 12, 2024
cakebaker
reviewed
May 12, 2024
cakebaker
reviewed
May 12, 2024
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
cksum-check
branch
2 times, most recently
from
5c118cd
to
415d655
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
@BenWiederhake I added tests on our side (ignored) for stuff that we don't support yet (and probably quite niche) |
BenWiederhake
requested changes
May 15, 2024
There was a problem hiding this comment.
Most of the problems I addressed are indeed fixed, and I mostly agree that it's a good idea to move most of the remainder for later. Hooray!
There are two exceptions that I think should be fixed in this PR:
- The new-ish issue
SHA4 (README.md) = 00000000, see above - The bit-rounding-down issue, which causes us to accept dubious and obviously-wrong hashes. This should be just a simple div-mod, right?
Things that should be fixed eventually, but perhaps not right now:
- "accept files with explicit algo but algos mismatch" details
- inconsistent behavior caused by the inclusion of
bin the algo-name regex:
$ echo 'bSD (README.md) = 0000' > foo.sums; cargo run -q cksum -c foo.sums
README.md: FAILED
cksum: WARNING: 1 computed checksum did NOT match
[$? = 1]
$ echo 'BsD (README.md) = 0000' > foo.sums; cargo run -q cksum -c foo.sums
cksum: foo.sums: no properly formatted checksum lines found
cksum: WARNING: 1 line is improperly formatted
[$? = 1]
|
Done :)
|
|
GNU testsuite comparison: |
sylvestre
changed the title
BenWiederhake
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.