ls: fix quoting alignment, add tests for default quoting style in TTY and quoting alignment #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenjiSann
force-pushed
the
main
branch
2 times, most recently
from
faa1d3d
to
c52e852
Compare
|
GNU testsuite comparison: |
|
I guess you saw that some jobs are failing |
Yes, sorry for that. I always forget about linting and windows stuff. |
|
GNU testsuite comparison: |
|
Forgot to add |
|
GNU testsuite comparison: |
|
@sylvestre if you don't mind taking look. I don't understand why is the macos test failing. |
|
@RenjiSann it isn't your fault. it is unrelated |
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6386