Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove all #[cfg(not(target_pointer_width = "128"))] #6418

Merged

Conversation

cakebaker
Copy link
Contributor

This PR removes all #[cfg(not(target_pointer_width = "128"))] to fix several "unexpected cfg condition value: 128" warnings in the CI (see, for example, https:/uutils/coreutils/actions/runs/9151519099/job/25157662399#step:11:377).

@tertsdiepraam
Copy link
Member

Ohh nice! Love it when the tooling improves to catch stuff like this

Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remaining CI failures are known issues #6275 and #6419.

@BenWiederhake BenWiederhake merged commit a816960 into uutils:main May 20, 2024
66 of 68 checks passed
@cakebaker cakebaker deleted the tests_remove_target_pointer_width_128 branch May 21, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants