cp: gnu test case preserve-mode fix #6432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was initially intended to fix GNU test preserve-mode, but as it turns out, there was nothing wrong with how
uu-cp
preserved mode. The test was failing because overriding wasn't working properly. The test involved copying a FIFO with options-a --preserve=mode
. The-a
was supposed to disable copying contents, but it was getting overridden by--preserve
wrongly. So, this PR now tries to fix the overriding of attributes.changes in behavior
-a
which expands to-dR --preserve=all
is given and a --preserve is given after that, cp would only override the --preserve part.--preserve
and--no-preserve
together in a single command, for examplecp --preserve=mode,ownership --no-preserve=ownership --preserve=link f f2
would preserve mode and link but not the ownership