Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

df: fix size column padding #6433

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

Qelxiros
Copy link
Contributor

Similarly to the Used column, GNU df pads an extra space to the right of the Size column.

@cakebaker
Copy link
Contributor

I have to admit I don't understand the reason for this change. Do you have an example where our output differs from the output of GNU df without this change?

@Qelxiros
Copy link
Contributor Author

Here's the output of df -h with GNU df and uutils df (Arch Linux 6.9.1-arch1-2, if it matters):
GNU:

Filesystem      Size  Used Avail Use% Mounted on
dev             3.7G     0  3.7G   0% /dev
run             3.8G  1.5M  3.8G   1% /run
efivarfs        246K   50K  192K  21% /sys/firmware/efi/efivars
/dev/nvme0n1p3  230G  136G   65G  68% /
tmpfs           3.8G   86M  3.7G   3% /dev/shm
tmpfs           3.8G   34M  3.7G   1% /tmp
/dev/nvme0n1p1  511M  165M  347M  33% /boot
tmpfs           761M   64K  761M   1% /run/user/1000

uutils:

Filesystem     Size  Used Avail Use% Mounted on
dev            3.7G     0  3.7G   0% /dev
run            3.8G  1.5M  3.8G   1% /run
efivarfs       246K   50K  192K  21% /sys/firmware/efi/efivars
/dev/nvme0n1p3 230G  136G   65G  68% /
tmpfs          3.8G   86M  3.7G   3% /dev/shm
tmpfs          3.8G   34M  3.7G   1% /tmp
/dev/nvme0n1p1 511M  165M  347M  33% /boot
tmpfs          761M   64K  761M   1% /run/user/1000

@cakebaker
Copy link
Contributor

Ah, now I see, good catch!

@cakebaker cakebaker merged commit 22588a8 into uutils:main May 27, 2024
61 of 68 checks passed
@cakebaker
Copy link
Contributor

Thanks!

@sylvestre
Copy link
Contributor

i wish it was covered by a test :(

@cakebaker
Copy link
Contributor

@sylvestre it's covered by an invalid test I'm currently fixing ;-)

@sylvestre
Copy link
Contributor

ok, merci :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants