Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp: Fix broken symlinks to parent-dir #6464

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on Jun 14, 2024

  1. cp: Fix broken symlinks to parent-dir

    According to the GNU cp official documentation[1], a symlink is only
    created if all source paths are absolute, unless the destination files
    are in the current directory.
    
    This fix solves this GNU cp incompatibility by:
    - Adding verifications when handling symlinks, to ensure that a symlink
      with relative path are only created if the destination is within the
      current directory.
    - Adding unit tests to cover this modifications, and ensure the behavior
      is correctly align with GNU documentation.
    
    [1]:
    https://www.gnu.org/software/coreutils/manual/html_node/cp-invocation.html#index-_002ds-16
    luigieli authored and cakebaker committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0589e94 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Configuration menu
    Copy the full SHA
    3cbc7d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Configuration menu
    Copy the full SHA
    c181a44 View commit details
    Browse the repository at this point in the history
  2. Fix broken test in Windows

    Due to the nature of Windows using backslash instead of regular slash to
    separate the directories, the test would fail because it was using a
    hardcoded output. To address that was changed the method to evaluate the
    output to a more flexible one, that way the backslash would not be a
    problem.
    luigieli committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    ce8c1b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    7358b5f View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    b12585d View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    67af1d2 View commit details
    Browse the repository at this point in the history