Refuse to translate if set2 contains more than one unique characters and set1 contains a character class #6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvonelm
force-pushed
the
issue-6344-complement-error-if-2-uniques
branch
2 times, most recently
from
f570cdb
to
202f5b6
Compare
|
GNU testsuite comparison: |
cvonelm
force-pushed
the
issue-6344-complement-error-if-2-uniques
branch
from
202f5b6
to
4c450c8
Compare
|
GNU testsuite comparison: |
wahou, bravo :) |
sylvestre
reviewed
Jun 16, 2024
| @@ -1386,3 +1386,22 @@ fn check_set1_longer_set2_ends_in_class_with_trunc() { | |||
| .args(&["-t", "[:lower:]a", "[:upper:]"]) | |||
| .succeeds(); | |||
| } | |||
|
|
|||
| fn check_complement_2_unique_in_set2() { | |||
There was a problem hiding this comment.
Suggested change
| fn check_complement_2_unique_in_set2() { | |
| #[test] | |
| fn check_complement_2_unique_in_set2() { |
sylvestre
reviewed
Jun 16, 2024
| @@ -262,6 +265,17 @@ impl Sequence { | |||
| .flat_map(Self::flatten_all) | |||
| .filter_map(to_u8) | |||
| .collect(); | |||
| let mut set2_uniques = set2_solved.clone(); | |||
There was a problem hiding this comment.
Suggested change
| let mut set2_uniques = set2_solved.clone(); | |
| // Ensure set2_solved contains unique elements only | |
| let mut set2_uniques = set2_solved.clone(); |
sylvestre
reviewed
Jun 16, 2024
| set2_uniques.sort(); | ||
| set2_uniques.dedup(); | ||
|
|
||
| if set1.iter().any(|x| matches!(x, Self::Class(_))) |
There was a problem hiding this comment.
Suggested change
| if set1.iter().any(|x| matches!(x, Self::Class(_))) | |
| // Validate the complement condition | |
| if set1.iter().any(|x| matches!(x, Self::Class(_))) |
cvonelm
force-pushed
the
issue-6344-complement-error-if-2-uniques
branch
from
4c450c8
to
bd772bc
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If complementing and translating with a character class, there can only be one unique character in set2.
The underlying issue, [y*] not being expanded to "" was fixed "accidentally" in a previous restructuring of tr. I have simply added the error check here.