Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNU tests: install attr #6784

Merged
merged 2 commits into from
Oct 18, 2024
Merged

GNU tests: install attr #6784

merged 2 commits into from
Oct 18, 2024

Conversation

sylvestre
Copy link
Contributor 

2024-10-16T07:22:20.6386088Z SKIP: tests/misc/xattr
2024-10-16T07:22:20.6386173Z ======================
2024-10-16T07:22:20.6386178Z 
2024-10-16T07:22:20.6386369Z ./tests/misc/xattr.sh: line 42: getfattr: command not found
2024-10-16T07:22:20.6386526Z xattr.sh: skipped test: failed to get xattr of file

cakebaker
cakebaker reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it on purpose that it is only installed for the gnu job but not the gnu_coverage job?

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/xattr. tests/misc/xattr is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

@sylvestre @cakebaker
GNU tests: install attr
aa11bab 
```
2024-10-16T07:22:20.6386088Z SKIP: tests/misc/xattr
2024-10-16T07:22:20.6386173Z ======================
2024-10-16T07:22:20.6386178Z 
2024-10-16T07:22:20.6386369Z ./tests/misc/xattr.sh: line 42: getfattr: command not found
2024-10-16T07:22:20.6386526Z xattr.sh: skipped test: failed to get xattr of file
```
@sylvestre @cakebaker
Also install attr for the GNU code coverage
976fa0e
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/xattr. tests/misc/xattr is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

@cakebaker cakebaker merged commit 96470d9 into main Oct 18, 2024
67 of 68 checks passed
@cakebaker cakebaker deleted the sylvestre-patch-3 branch October 18, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker