hashsum: implement SHAKE-128 and SHAKE-256 #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
added a commit
to str4d/coreutils
that referenced
this pull request
Jun 4, 2022
Several binaries have been added to `hashsum` that have never been part of GNU Coreutils: - `sha3*sum` (uutils#869) - `shake*sum` (uutils#987) - `b3sum` (uutils#3108 and uutils#3164) In particular, the `--bits` option, and the `--no-names` option added in uutils#3361, are not valid for any GNU Coreutils `*sum` binary (as of Coreutils 9.0). This commit refactors the argument parsing so that `--bits` and `--no-names` become invalid options for the binaries intended to match the GNU Coreutils API, instead of being ignored options. It also refactors the custom binary name handling to distinguish between binaries intended to match the GNU Coreutils API, and binaries that don't have that constraint. Part of uutils#2930.
str4d
added a commit
to str4d/coreutils
that referenced
this pull request
Jun 4, 2022
Several binaries have been added to `hashsum` that have never been part of GNU Coreutils: - `sha3*sum` (uutils#869) - `shake*sum` (uutils#987) - `b3sum` (uutils#3108 and uutils#3164) In particular, the `--bits` option, and the `--no-names` option added in uutils#3361, are not valid for any GNU Coreutils `*sum` binary (as of Coreutils 9.0). This commit refactors the argument parsing so that `--bits` and `--no-names` become invalid options for the binaries intended to match the GNU Coreutils API, instead of being ignored options. It also refactors the custom binary name handling to distinguish between binaries intended to match the GNU Coreutils API, and binaries that don't have that constraint. Part of uutils#2930.
str4d
added a commit
to str4d/coreutils
that referenced
this pull request
Jun 5, 2022
Several binaries have been added to `hashsum` that have never been part of GNU Coreutils: - `sha3*sum` (uutils#869) - `shake*sum` (uutils#987) - `b3sum` (uutils#3108 and uutils#3164) In particular, the `--bits` option, and the `--no-names` option added in uutils#3361, are not valid for any GNU Coreutils `*sum` binary (as of Coreutils 9.0). This commit refactors the argument parsing so that `--bits` and `--no-names` become invalid options for the binaries intended to match the GNU Coreutils API, instead of being ignored options. It also refactors the custom binary name handling to distinguish between binaries intended to match the GNU Coreutils API, and binaries that don't have that constraint. Part of uutils#2930.
sylvestre
pushed a commit
to str4d/coreutils
that referenced
this pull request
Jun 10, 2022
Several binaries have been added to `hashsum` that have never been part of GNU Coreutils: - `sha3*sum` (uutils#869) - `shake*sum` (uutils#987) - `b3sum` (uutils#3108 and uutils#3164) In particular, the `--bits` option, and the `--no-names` option added in uutils#3361, are not valid for any GNU Coreutils `*sum` binary (as of Coreutils 9.0). This commit refactors the argument parsing so that `--bits` and `--no-names` become invalid options for the binaries intended to match the GNU Coreutils API, instead of being ignored options. It also refactors the custom binary name handling to distinguish between binaries intended to match the GNU Coreutils API, and binaries that don't have that constraint. Part of uutils#2930.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added tests for SHA3.