Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible matchers implemented via config struct and predicate lists #431

Open
hanbings opened this issue Aug 1, 2024 · 0 comments
Open

Comments

@hanbings
Copy link
Collaborator

hanbings commented Aug 1, 2024

Organize the configurations that need to be passed from the argument parser to the matcher.

For example, in the implementation of -follow, we need to use config.follow from the argument parser to pass a follow: bool to TimeMatcher. Can we change it to config: &Config to pass Config directly without repeatedly modifying these parts of the code when adding other options in the future?

And can we centralize these predicate logics by passing a predicate list or maintaining a predicate list in Config? In this way, we don't need to modify Matcher one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant