Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize handling of uucore::error::set_exit_code() calls. #440

Closed
hanbings opened this issue Aug 11, 2024 · 1 comment · Fixed by #436
Closed

Centralize handling of uucore::error::set_exit_code() calls. #440

hanbings opened this issue Aug 11, 2024 · 1 comment · Fixed by #436
Labels
bug

Comments

@hanbings
Copy link
Collaborator

refer: #421 (comment)

This could be a method on MatcherIO, and then you wouldn't need to unset it in the tests

Note: Currently we have two uucore::error::set_exit_code() in the entire find code.
@hanbings hanbings added the bug label Aug 11, 2024
@tavianator
Copy link
Contributor

This is done in e73334f

@tavianator tavianator mentioned this issue Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap walkdir::DirEntry in a new type tavianator/findutils
2 participants
@tavianator @hanbings