POSIX compliant globs #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glob crate exposes .gitignore style globs with recursive (**) matching and other features. find should implement globs exactly as specified by POSIX. Do this by translating them to POSIX Basic Regular Expressions. Fixes #140.
|
bfs
GNU
Windows tests are failing due to path separators, |
Now that -path/-ipath is implemented, no tests are skipped any more. Fix CI by using zero instead of the empty string, which breaks the compare_bfs_result.py script.
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 53.15% 53.68% +0.53%
==========================================
Files 25 28 +3
Lines 4739 4802 +63
Branches 1561 1574 +13
==========================================
+ Hits 2519 2578 +59
- Misses 1671 1674 +3
- Partials 549 550 +1
Continue to review full report at Codecov.
|
|
Impressive! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements POSIX-compliant globs for
-name,-lname, and the new-path. I couldn't find an existing crate that providedfnmatch()semantics exactly, so I implemented the conversion to POSIX regexes myself.