options return true #417
Merged
options return true #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tavianator
commented
Jul 10, 2024
tavianator
commented
- find: Options like -maxdepth return true
- find: Stop parsing after we see -help or -version
Previously, this would give an error:
$ find -maxdepth 0 -a -print
Error: invalid expression; you have used a binary operator '-a' with nothing before it.
Now, options are treated like other primary expressions:
$ find -maxdepth 0 -a print
.
GNU find accepts things like
$ find \( -help -foo -not
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 65.57% 65.74% +0.16%
==========================================
Files 34 34
Lines 3951 3953 +2
Branches 905 905
==========================================
+ Hits 2591 2599 +8
+ Misses 1002 998 -4
+ Partials 358 356 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.