Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 18 #187

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Upgrade to React 18 #187

merged 2 commits into from
Apr 19, 2024

Conversation

carolynzhang18
Copy link
Contributor

@carolynzhang18 carolynzhang18 commented Apr 3, 2024

Notion ticket link

Update React version

Implementation description

  • Bumped React up to v18.x.x in frontend/
  • Bumped Node up to v20.11.1 (latest stable version right now) everywhere
  • The rest of the changes are just fixes based on linting with the upgraded linter

Steps to test

  1. Go to the frontend directory - cd frontend
  2. Delete node_modules - rm -r node_modules - if you have them (if not, ignore this step).
  3. Run yarn install.
  4. Run yarn start.
    Expected: everything should compile and localhost should be up:
    image
    image

What should reviewers focus on?

  • The frontend compiles... but not sure how well it plays w/ backend and querying...
  • One change I'm slightly iffy about: I had to comment out the // import { decamelizeKeys } from "humps"; in CreateForm.tsx and UpdateForm.tsx to dodge some linter warnings about unused vars. This seems probably fine - scroll down a bit in either file and there are other examples of whole blocks of commented out code marked with // python {

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

github-actions bot commented Apr 3, 2024

Visit the preview URL for this PR (updated for commit badf90f):

https://uw-blueprint-starter-code--pr187-carolyn-upgrade-reac-f3vby7y1.web.app

(expires Mon, 15 Apr 2024 01:11:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8a9d9b9ea27110b294ec3954ff89dab270e34c45

@carolynzhang18 carolynzhang18 linked an issue Apr 3, 2024 that may be closed by this pull request
@carolynzhang18 carolynzhang18 changed the title Upgrade React, Node, and linter Upgrade to React 18 Apr 3, 2024
* Change backend port to 8080

* Run backend linter

* Restore timer value

* Add 8080

---------

Co-authored-by: Owen Sellner <[email protected]>
Copy link

@achandrabalan achandrabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@achandrabalan
Copy link

You rn ^

Copy link
Contributor

@owen-sellner owen-sellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected, great job!!!

@carolynzhang18 carolynzhang18 merged commit e01294e into main Apr 19, 2024
3 checks passed
@carolynzhang18 carolynzhang18 deleted the carolyn/upgrade-react-version branch April 19, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Frontend to React 18
3 participants