Disable freezing V8 flags on initialization #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node still changes flags after initializationg; either because tests need to set their own flags (which V8 tests also still allow), or because it's explicitly requested via the "v8.setFlagsFromString" method that Node provides.
|
@victorgomes are you the right contact to approve/merge this? |
|
The failures look unrelated to my change. Any idea what's wrong? Am I merging into the wrong branch? |
jakobkummerow
approved these changes
Jun 13, 2022
|
@pthier as Victor is OOO, can you take a look please? |
|
I have never really looked at the github ci checks (and apparently no one did). I will try to resolve the issues the next time I sync our repo with upstream. Definitely not related to your changes. |
|
Thanks, Patrick! |
pthier
pushed a commit
that referenced
this pull request
Jun 14, 2022
Node still changes flags after initializationg; either because tests need to set their own flags (which V8 tests also still allow), or because it's explicitly requested via the "v8.setFlagsFromString" method that Node provides.
pthier
pushed a commit
that referenced
this pull request
Jul 20, 2022
Node still changes flags after initializationg; either because tests need to set their own flags (which V8 tests also still allow), or because it's explicitly requested via the "v8.setFlagsFromString" method that Node provides.
victorgomes
pushed a commit
that referenced
this pull request
Aug 11, 2022
Node still changes flags after initializationg; either because tests need to set their own flags (which V8 tests also still allow), or because it's explicitly requested via the "v8.setFlagsFromString" method that Node provides.
pthier
pushed a commit
that referenced
this pull request
Sep 22, 2022
Node still changes flags after initializationg; either because tests need to set their own flags (which V8 tests also still allow), or because it's explicitly requested via the "v8.setFlagsFromString" method that Node provides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node still changes flags after initializationg; either because tests
need to set their own flags (which V8 tests also still allow), or
because it's explicitly requested via the "v8.setFlagsFromString" method
that Node provides.