docs: add grid empty state documentation #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
DiegoCardoso
approved these changes
Jun 17, 2024
Comment on lines
14
to
16
| {/* tag::snippet[] */} | ||
| <span slot="empty-state">No employees found.</span> | ||
| {/* end::snippet[] */} |
There was a problem hiding this comment.
Snippets for React / Lit should include the grid definition IMO, otherwise it may be confusing what to do with that single line.
sissbruecker
approved these changes
Jun 17, 2024
|
@jouni why change the base to |
russelljtdyer
added
Language checking
|
@tomivirkki because new, non-breaking, features are always merged to latest, and indicated with the versioning badge. vaadin.com/docs/next should redirect to vaadin.com/docs/latest until we need a breaking change in the docs again. |
|
@jouni Since this PR includes code examples that require API from |
|
Yes, we do need to update the version to be able to use new APIs. |
tomivirkki
force-pushed
the
docs/grid-empty-state
branch
from
8bf0ac9
to
c2e8d47
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for the Grid empty state feature
Part of vaadin/platform#5719