improve test coverage

vaadin · Jul 22, 2022 · f59b6fe · f59b6fe
1 parent e71f3cc
commit f59b6fe
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/...java/com/vaadin/flow/component/textfield/tests/validation/AbstractValidationBinderIT.java b/...java/com/vaadin/flow/component/textfield/tests/validation/AbstractValidationBinderIT.java
@@ -38,6 +38,7 @@ public void init() {
  public void required_fieldIsInitiallyValid() {
  assertClientValid(true);
  assertServerValid(true);
+ assertErrorMessage(null);
  }
 
  @Test

diff --git a/...ava/com/vaadin/flow/component/textfield/tests/validation/TextFieldValidationBinderIT.java b/...ava/com/vaadin/flow/component/textfield/tests/validation/TextFieldValidationBinderIT.java
@@ -35,6 +35,7 @@ public void minLength_changeInputValue_assertValidity() {
  field.setValue("A");
  assertClientValid(false);
  assertServerValid(false);
+ assertErrorMessage("");
 
  // Binder validation fails:
  field.setValue("AA");
@@ -60,6 +61,7 @@ public void maxLength_changeInputValue_assertValidity() {
  field.setValue("AAA");
  assertClientValid(false);
  assertServerValid(false);
+ assertErrorMessage("");
 
  // Binder validation fails:
  field.setValue("AA");
@@ -85,6 +87,7 @@ public void pattern_changeInputValue_assertValidity() {
  field.setValue("Word");
  assertClientValid(false);
  assertServerValid(false);
+ assertErrorMessage("");
 
  // Binder validation fails:
  field.setValue("12");

diff --git a/...test/java/com/vaadin/flow/component/textfield/tests/validation/TextFieldValidationIT.java b/...test/java/com/vaadin/flow/component/textfield/tests/validation/TextFieldValidationIT.java
@@ -29,10 +29,14 @@ public void minLength_changeInputValue_assertValidity() {
  $("input").id(TextFieldValidationPage.MIN_LENGTH_INPUT).sendKeys("2",
  Keys.ENTER);
 
- field.setValue("AA");
+ field.setValue("A");
  assertClientValid(false);
  assertServerValid(false);
 
+ field.setValue("AA");
+ assertClientValid(true);
+ assertServerValid(true);
+
  field.setValue("AAA");
  assertClientValid(true);
  assertServerValid(true);
@@ -43,10 +47,14 @@ public void maxLength_changeInputValue_assertValidity() {
  $("input").id(TextFieldValidationPage.MAX_LENGTH_INPUT).sendKeys("2",
  Keys.ENTER);
 
- field.setValue("AA");
+ field.setValue("AAA");
  assertClientValid(false);
  assertServerValid(false);
 
+ field.setValue("AA");
+ assertClientValid(true);
+ assertServerValid(true);
+
  field.setValue("A");
  assertClientValid(true);
  assertServerValid(true);