fix!: change search endpoint log level to debug #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 24.4 the mechanism for hot-reloading the endpoint related changes is either based on HotSwapAgent or through Polling the changes, and when using polling by enabling the `hilla.endpoint.hot-reload` this INFO level log is annoying for the developers, since in most of the projects the endpoints are right there in the project and that log is not helping very much, and in other cases when there's a problem, the log level can easily be changed to debug to see this. Based on internal discussion there is no need to make the Parser's code unnecessarily complicated just to have different log levels conditionally.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 24.4 #2483 +/- ##
=======================================
Coverage ? 95.01%
=======================================
Files ? 66
Lines ? 4557
Branches ? 661
=======================================
Hits ? 4330
Misses ? 183
Partials ? 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Artur-
approved these changes
May 28, 2024
|
|
This is probably not needed in main, since the polling mechanism for endpoint hot reload is removed completely. |
vaadin-bot
pushed a commit
that referenced
this pull request
May 29, 2024
In 24.4 the mechanism for hot-reloading the endpoint related changes is either based on HotSwapAgent or through Polling the changes, and when using polling by enabling the `hilla.endpoint.hot-reload` this INFO level log is annoying for the developers, since in most of the projects the endpoints are right there in the project and that log is not helping very much, and in other cases when there's a problem, the log level can easily be changed to debug to see this. Based on internal discussion there is no need to make the Parser's code unnecessarily complicated just to have different log levels conditionally.
Lodin
pushed a commit
that referenced
this pull request
May 30, 2024
|
This ticket/PR has been released with Hilla 24.4.0.rc1 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 24.4 the mechanism for hot-reloading the endpoint related changes is either based on HotSwapAgent or through Polling the changes, and when using polling by enabling the
hilla.endpoint.hot-reloadthis INFO level log is annoying for the developers, since in most of the projects the endpoints are right there in the project and that log is not helping very much, and in other cases when there's a problem, the log level can easily be changed to debug to see this.Based on internal discussion there is no need to make the Parser's code unnecessarily complicated just to have different log levels conditionally.
Fixes #2476
Type of change
Checklist