Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send updates only when not rendering #2707

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Conversation

krissvaa
Copy link
Contributor

@krissvaa krissvaa commented Sep 6, 2024

React doesn't allow updates to state while rendering.
Reference

Fixes: #2643

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (5d5a0fd) to head (7f66ef8).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2707   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files          80       80           
  Lines        2551     2551           
  Branches      661      661           
=======================================
  Hits         2407     2407           
  Misses        140      140           
  Partials        4        4           
Flag Coverage Δ
unittests 94.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krissvaa krissvaa marked this pull request as ready for review September 9, 2024 14:32
taefi
taefi previously approved these changes Sep 10, 2024
Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal, LGTM!
Just added one minor comment.

Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@platosha platosha merged commit d000bee into main Sep 11, 2024
14 of 15 checks passed
@platosha platosha deleted the feat/update-component branch September 11, 2024 11:01
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.5.0.alpha15 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Dev-Mode, AutoCrud throws error when selecting an entity of which one field has the value null
4 participants