fix: undefined representation as empty in string components #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
=======================================
Coverage 94.52% 94.53%
=======================================
Files 81 81
Lines 2629 2633 +4
Branches 678 680 +2
=======================================
+ Hits 2485 2489 +4
Misses 140 140
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
previously requested changes
Sep 18, 2024
Co-authored-by: Soroosh Taefi <[email protected]>
* Initialize value and default value only when requested Fixes #2670 * Add karma custom chrome launcher without search-engine choice screen
platosha
reviewed
Sep 18, 2024
|
platosha
approved these changes
Sep 18, 2024
|
This ticket/PR has been released with Hilla 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non Vaadin components - fix undefined value representation
Fixes #2658