Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Hilla package and update deps #244

Merged
merged 19 commits into from
Feb 21, 2024
Merged

Conversation

heruan
Copy link
Member

@heruan heruan commented Feb 12, 2024

This follows #243 with the missing changes and closes #242

@heruan heruan self-assigned this Feb 12, 2024
@heruan heruan marked this pull request as draft February 12, 2024 12:53
@heruan
Copy link
Member Author

heruan commented Feb 12, 2024

Converting to draft to wait for the @vaadin/hilla-core ➡️ @vaadin/hilla-frontend rename.

@heruan heruan marked this pull request as ready for review February 14, 2024 12:42
@heruan
Copy link
Member Author

heruan commented Feb 14, 2024

Demos still don't run, fixing them after next alpha.

MatthewVaadin
MatthewVaadin previously approved these changes Feb 16, 2024
@manolo
Copy link
Member

manolo commented Feb 21, 2024

When I run:

git clone [email protected]:vaadin/observability-kit.git
cd observability-kit/
git checkout chore/rename-hilla-package
mvn clean install -DskipTests -U
cd observability-kit-demo-hilla
mvn -Dspring-boot.run.arguments="--com.example.application.hilla.auth.secret=here_my_app_secret_key"

I get the following error in a loop:

Caused by: com.vaadin.flow.server.ExecutionFailedException: Npm install has exited with non zero status. Some dependencies are not installed. Check npm command output
	at com.vaadin.flow.server.frontend.TaskRunNpmInstall.runNpmInstall(TaskRunNpmInstall.java:334) ~[flow-server-24.4-SNAPSHOT.jar:24.4-SNAPSHOT]

Then I run

npm i

And the error is

npm ERR! code 1
npm ERR! path /private/tmp/o11y/observability-kit/ts/observability-kit-client
npm ERR! command failed
npm ERR! command sh -c npm run build
npm ERR! > @vaadin/[email protected] build
npm ERR! > concurrently npm:build:code npm:build:dts
npm ERR! sh: concurrently: command not found
npm ERR! npm ERR! Lifecycle script `build` failed with error:
npm ERR! npm ERR! Error: command failed
npm ERR! npm ERR!   in workspace: @vaadin/[email protected]
npm ERR! npm ERR!   at location: /private/tmp/o11y/observability-kit/ts/observability-kit-client

The culprit is

./ts/observability-kit-client/package.json:    "build": "concurrently npm:build:code npm:build:dts",

but If I try

npm i concurrently --save

it fails because observability-kit-client needs to be installed first

npm ERR! code 1
npm ERR! path /private/tmp/o11y/observability-kit/ts/observability-kit-client
npm ERR! command failed
npm ERR! command sh -c npm run build
npm ERR! > @vaadin/[email protected] build
npm ERR! > concurrently npm:build:code npm:build:dts
npm ERR! sh: concurrently: command not found
npm ERR! npm ERR! Lifecycle script `build` failed with error:
npm ERR! npm ERR! Error: command failed
npm ERR! npm ERR!   in workspace: @vaadin/[email protected]
npm ERR! npm ERR!   at location: /private/tmp/o11y/observability-kit/ts/observability-kit-client

@heruan
Copy link
Member Author

heruan commented Feb 21, 2024

The concurrently dependency is defined in the root package.json:

"concurrently": "^7.6.0",

It is installed with npm install from the project root, and then it's found by the submodules looking in ../node_modules (by default).

@heruan heruan merged commit 2f72bc5 into main Feb 21, 2024
2 checks passed
@heruan heruan deleted the chore/rename-hilla-package branch February 21, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Hilla packages for 24.4
3 participants