-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover component #5271
Comments
Allow lazy loading of popover content. The popover content on the server side should only instantiiate once the popover is opened; not on the initial page load. This might need some styling within the popover? Like a spinner / loading indicator so that the popover opens with e.g. 10x10rem and a spinner until the content was fetched so that the user gets instant feedback even for slower server inquiries. (Or: add a loading property the user can use for styling) |
Minor addition: box-shadow should include a 1px outline in addition to box-shadow-m, like other overlays, but that should like already come from here: https:/vaadin/web-components/blob/main/packages/vaadin-lumo-styles/mixins/overlay.js#L27 |
This is clearly only a potential future refactoring option, but just want to remind that the CSS anchor positioning API is what we should eventually use. It’s available in Chrome today. Similarly as the |
@rolfsmeds Do you also plan to add first-class integration into the Grid like done with the Tooltip so that I can use the Popover as alternative in there? I can see a lot of business application needing this kind of Popover. |
Hadn't thought about that, actually, but it's a good idea. Would you mind creating a ticket for it @knoobie? |
We could update this epic and sneak it in there 😏 half joking; creating one tomorrow |
Description
A generic component for creating popovers positioned to an anchor element.
(Different from tooltips in that popovers can contain interactive elements like buttons and input fields.)
Use cases
Acceptance criteria
vaadin-popover
, Flow componentPopover
, React component<Popover>
Positioning
Modality and focus
Open/close behavior
Accessibility
aria-label
andaria-labelledby
Styling
--lumo-base-color
,--lumo-box-shadow-m
.Miscellaneous
Possible later enhancements:
General criteria
Security
The text was updated successfully, but these errors were encountered: