fix: hide overlay if position target element is hidden #7454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the target element is hidden, either by having `display: none` set to itself of any of its parents, a resize observer for that element is triggered. This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden. Fixes #7437
|
web-padawan
approved these changes
May 28, 2024
DiegoCardoso
commented
May 28, 2024
| @@ -232,6 +232,11 @@ export const PositionMixin = (superClass) => | |||
|
|
|||
| const targetRect = this.positionTarget.getBoundingClientRect(); | |||
|
|
|||
| if (targetRect.width === 0 && targetRect.height === 0 && this.opened) { | |||
There was a problem hiding this comment.
Note: this condition can be potentially refactored to use !this.positionTarget.checkVisibility() && this.opened, but checkVisibility is only supported in Safari 17.4+.
tomivirkki
reviewed
May 28, 2024
tomivirkki
approved these changes
May 28, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 28, 2024
* fix: hide overlay if position target element is hidden If the target element is hidden, either by having `display: none` set to itself of any of its parents, a resize observer for that element is triggered. This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden. Fixes #7437
vaadin-bot
pushed a commit
that referenced
this pull request
May 28, 2024
* fix: hide overlay if position target element is hidden If the target element is hidden, either by having `display: none` set to itself of any of its parents, a resize observer for that element is triggered. This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden. Fixes #7437
vaadin-bot
pushed a commit
that referenced
this pull request
May 28, 2024
* fix: hide overlay if position target element is hidden If the target element is hidden, either by having `display: none` set to itself of any of its parents, a resize observer for that element is triggered. This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden. Fixes #7437
DiegoCardoso
added a commit
that referenced
this pull request
May 28, 2024
…4.3) (#7457) * fix: hide overlay if position target element is hidden If the target element is hidden, either by having `display: none` set to itself of any of its parents, a resize observer for that element is triggered. This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden. Fixes #7437 Co-authored-by: Diego Cardoso <[email protected]>
DiegoCardoso
added a commit
that referenced
this pull request
May 28, 2024
…4.4) (#7456) * fix: hide overlay if position target element is hidden If the target element is hidden, either by having `display: none` set to itself of any of its parents, a resize observer for that element is triggered. This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden. Fixes #7437 Co-authored-by: Diego Cardoso <[email protected]>
DiegoCardoso
added a commit
that referenced
this pull request
May 28, 2024
…3.5) (#7455) * fix: hide overlay if position target element is hidden (#7454) * fix: hide overlay if position target element is hidden If the target element is hidden, either by having `display: none` set to itself of any of its parents, a resize observer for that element is triggered. This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden. Fixes #7437 * chore: add missing nextRender import * test: import text-field in combo-box-light mock test --------- Co-authored-by: Diego Cardoso <[email protected]>
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the target element is hidden, either by having
display: noneset to itself or any of its parents, a resize observer for that element is triggered.This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden.
Fixes #7437
Type of change