Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable KV WAL for all write operations #130

Closed
valeriansaliou opened this issue Apr 19, 2019 · 1 comment
Closed

Ability to disable KV WAL for all write operations #130

valeriansaliou opened this issue Apr 19, 2019 · 1 comment
Assignees
Labels
enhancement Enhancement to an existing feature
Milestone

Comments

@valeriansaliou
Copy link
Owner

WAL would be enabled by default, but could be turned off in the configuration.

This could dramatically improve SSD lifetime on busy servers. Ie. at Crisp's we see a sustained write rate of 2MB/s over all our KV collections, which is fine but could lead to issues over long periods of time.

We would need to force a memtables flush to RocksDB SST files on process shutdown, as to ensure the in-memory log is committed to disk before Sonic goes down.

@valeriansaliou valeriansaliou added the enhancement Enhancement to an existing feature label Apr 19, 2019
@valeriansaliou valeriansaliou added this to the v1.3.0 milestone Apr 19, 2019
@valeriansaliou valeriansaliou self-assigned this Apr 19, 2019
@valeriansaliou valeriansaliou changed the title Ability to disable KV WAL for write operations Ability to disable KV WAL for all write operations Apr 19, 2019
@valeriansaliou
Copy link
Owner Author

We would also need to check if that's needed for batch deletes + atomic deletes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant