Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server statistics over control channel #70

Closed
6 tasks done
valeriansaliou opened this issue Mar 23, 2019 · 3 comments
Closed
6 tasks done

Server statistics over control channel #70

valeriansaliou opened this issue Mar 23, 2019 · 3 comments
Labels
enhancement Enhancement to an existing feature good first issue Good for newcomers
Milestone

Comments

@valeriansaliou
Copy link
Owner

valeriansaliou commented Mar 23, 2019

Currently, Sonic does not provide any information on its current status and load.

A statistics command (eg. INFO) could be made available via Sonic Channel in control mode, providing information on:

  • Server uptime: uptime
  • Connected clients: clients_connected
  • Total commands: commands_total
  • Command latency (best + worst): command_latency_best + command_latency_worst
  • Count of open KVs and FSTs: kv_open_count + fst_open_count
  • Count of FSTs pending consolidation: fst_consolidate_count

Command flow example:

> INFO
< RESULT uptime(3600) clients_connected(12) commands_total(1002939) command_latency_best(1) command_latency_worst(1) kv_open_count(6) fst_open_count(182) fst_consolidate_count(89)
@valeriansaliou valeriansaliou added enhancement Enhancement to an existing feature good first issue Good for newcomers labels Mar 23, 2019
@valeriansaliou valeriansaliou added this to the v1.2.0 milestone Mar 23, 2019
@valeriansaliou
Copy link
Owner Author

Add RocksDB statistics: https:/facebook/rocksdb/wiki/RocksDB-Tuning-Guide#rocksdb-statistics

@valeriansaliou
Copy link
Owner Author

valeriansaliou commented Apr 15, 2019

  1. As a first step, the protocol needs to be defined there (command and expected result).
  2. Then, an implementation needs to be done.
  3. Finally, the statistics command needs to be added to Sonic Channel libraries.

@valeriansaliou
Copy link
Owner Author

valeriansaliou commented Apr 15, 2019

As enabling RocksDB statistics adds a 5%-10% overhead, choice has been made not to report those. See: https:/facebook/rocksdb/wiki/Statistics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant