Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests #154

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Integration Tests #154

merged 2 commits into from
Jul 8, 2019

Conversation

vilunov
Copy link
Contributor

@vilunov vilunov commented Jul 3, 2019

This pull request proposes a framework for integration testing of Sonic. It uses Node.js as a runtime for tests. and the Sonic Channel client library.

The test suite is organized into scenarios, each running in an isolated Sonic state, i.e. the index is empty at the start and discarded after running the scenario. All scenarios are to be ran even if one of scenarios is already confirmed to be failed in order to detect all possible errors.

Currently the suite is rather poor and contains only two simple tests: ping and insert/query.

@valeriansaliou
Copy link
Owner

Thanks! I'll review this over the weekend.

@valeriansaliou valeriansaliou merged commit 4b59f9f into valeriansaliou:master Jul 8, 2019
@valeriansaliou
Copy link
Owner

Perfect! I've validated tests and they work fine, I've reworked the structure and code style without changing the meaning of your code. I've also added copyright headers, crediting you the work.

You can add more integration tests if you feel like to!

Thanks again!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants