Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all words from the bucket control operator #293

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

trkohler
Copy link

@trkohler trkohler commented Oct 1, 2022

resolve #177

@trkohler
Copy link
Author

trkohler commented Oct 1, 2022

if possible, could you please add hacktoberfest label to the PR?
because otherwise it won't be count for me.

@valeriansaliou valeriansaliou added feature Anything that is related to a new feature hacktoberfest-accepted Hacktoberfest-related issues and PRs labels Oct 1, 2022
@valeriansaliou
Copy link
Owner

Thank you for the PR. The label has been added. I'm currently in holidays / so AFK, I'll review and merge this when I am back.

@trkohler
Copy link
Author

trkohler commented Oct 1, 2022

thanks, sure. no hurry!

just FYI, that's from the hacktober site:

MUST BE IN A REPO TAGGED WITH THE “HACKTOBERFEST” TOPIC, OR BE LABELED “HACKTOBERFEST-ACCEPTED.”

probably label needs to be changed to hacktoberfest-accepted to be counted because I guess there is some robot watching those and currently this PR is not counted in the dashboard.

@valeriansaliou
Copy link
Owner

Label updated, is it okay now?

@trkohler
Copy link
Author

trkohler commented Oct 1, 2022

yes! it's accepted by hacktoberfest, now I would patiently wait for you to be back and review.

@trkohler
Copy link
Author

trkohler commented Oct 8, 2022

@valeriansaliou gentle ping on my PR in case you forgot about it 👀

@valeriansaliou
Copy link
Owner

Still in holidays, it’s on my todo to review no worries ;)

@valeriansaliou
Copy link
Owner

Will merge now, some refactors are on the way, eg. moving the LIST command from the Control channel to the Search channel.

@valeriansaliou valeriansaliou merged commit 69c6569 into valeriansaliou:master Oct 20, 2022
@valeriansaliou
Copy link
Owner

valeriansaliou commented Oct 20, 2022

Released Sonic v1.4.0 w/ the LIST command available in search mode. Also added support for .list() in node-sonic-channel. Thanks for all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Anything that is related to a new feature hacktoberfest-accepted Hacktoberfest-related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List all terms/words indexed in a bucket
2 participants