-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build tooling and exports #1869
Draft
tux-tn
wants to merge
25
commits into
validatorjs:master
Choose a base branch
from
tux-tn:chore/Tooling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf02e1c.
- Bump build dependencies - Use rollup for all outputs to reduce building time - Transpile to modern es2017 code for browsers supporting es modules using `@babel/preset-modules` - Give hints to javascript bundlers about source for es modules and browser script to use - Migrate from uglifyjs to terser (Allow minifying for modern browsers)
We are in 2021, bower was deprecated a long time ago
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 103 103
Lines 2097 1949 -148
Branches 473 0 -473
==========================================
- Hits 2097 1949 -148
Continue to review full report at Codecov.
|
- disable max-len for regexes
1 task
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: This is a big update
Mainly what have been done:
We had multiple commands for building for browser, node and es6. Since we are already using rollup, i merged all needed bundles in one single config file and command to allow easier maintenance over time.
ES6 for browsers
that generates minifiedmjs
files (Not sure if we should keep two es6 exports or just themjs
one, may be @fedeci can provide some feedback on this) targeting modern browsers (Browsers and versions of NodeJS that support JS imports to be more specific)package.json
.NodeJS 0.10
).One of the big problems of our ES6 exports is that we are not allowing tree-shaking as we can see in #1593 #1759 #683 and many more issues.
index.es.js
has been added in order to allow tree-shaking for es6 exports. Now we can hopefully import validators in multiples ways:Other changes:
source
,module
andbrowser entries to
package.json` (Not sure if we should keep source/browser since they are only giving hints)What need to be done: