Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation for Pakistan's passport #2073

Closed
wants to merge 8 commits into from

Conversation

digambar-t7
Copy link
Contributor

Fixes #2072

This adds the validation for Pakistani passport

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (a6ea7ef) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2073   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

rubiin
rubiin previously approved these changes Oct 17, 2022
@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 17, 2022
@rubiin
Copy link
Member

rubiin commented Oct 17, 2022

@digambar-t7 fix the merge conflict and we are ready to go

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @digambar-t7 ,
Country codes need to follow ISO 3166-1 alpha-2. It means it should be PK and PH !

@tux-tn tux-tn added 🧹 needs-update For PRs that need to be updated before landing and removed mc-to-land Just merge-conflict standing between the PR and landing. labels Oct 18, 2022
@digambar-t7
Copy link
Contributor Author

Ok @tux-tn , will be back soon.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @digambar-t7 for the quick edits! LGTM 🎉
Is your contribution part of Hacktoberfest?

@digambar-t7
Copy link
Contributor Author

Yes @tux-tn , it is a part of my Hactoberfest contribution.

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed hacktoberfest-accepted and removed 🧹 needs-update For PRs that need to be updated before landing labels Oct 18, 2022
@profnandaa profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. and removed ready-to-land For PRs that are reviewed and ready to be landed labels Feb 1, 2023
@profnandaa
Copy link
Member

Sorry missed this in my latest clean-ups, I should get this in #2164.

@@ -154,7 +154,7 @@ Validator | Description
**isMultibyte(str)** | check if the string contains one or more multibyte chars.
**isNumeric(str [, options])** | check if the string contains only numbers.<br/><br/>`options` is an object which defaults to `{no_symbols: false}` it also has locale as an option. If `no_symbols` is true, the validator will reject numeric strings that feature a symbol (e.g. `+`, `-`, or `.`).<br/><br/>`locale` determine the decimal separator and is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bg-BG', 'cs-CZ', 'da-DK', 'de-DE', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'es-ES', 'fr-FR', 'fr-CA', 'hu-HU', 'it-IT', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'sl-SI', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'tr-TR', 'uk-UA']`.
**isOctal(str)** | check if the string is a valid octal number.
**isPassportNumber(str, countryCode)** | check if the string is a valid passport number.<br/><br/>(countryCode is one of `[ 'AM', 'AR', 'AT', 'AU', 'BE', 'BG', 'BY', 'BR', 'CA', 'CH', 'CN', 'CY', 'CZ', 'DE', 'DK', 'DZ', 'EE', 'ES', 'FI', 'FR', 'GB', 'GR', 'HR', 'HU', 'IE' 'IN', 'IR', 'ID', 'IS', 'IT', 'JP', 'KR', 'LT', 'LU', 'LV', 'LY', 'MT', 'MX', 'MY', 'MZ', 'NL', 'PL', 'PT', 'RO', 'RU', 'SE', 'SL', 'SK', 'TH', 'TR', 'UA', 'US' ]`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@profnandaa same here about the 'TH'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing manually in #2164

profnandaa added a commit that referenced this pull request Feb 2, 2023
* maintentance: clean up, closes #2073 
---------

Co-authored-by: Digambar Tupurwadi <digz@kali>
Co-authored-by: Digambar <[email protected]>
@profnandaa
Copy link
Member

merged in #2164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. PR/combined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pakistan passport number validation
6 participants